Review Request 114055: Include translatoins sub-directory to CMakeLists.txt , Fedora Packaging fails searching for translations

Sinny Kumari ksinny at gmail.com
Tue Nov 26 11:40:33 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114055/#review44489
-----------------------------------------------------------

Ship it!


looks good to me. I checked on Fedora 19 and translation works fine there.
It would be great to know from others as well if these changes don't create any problem in other distro.

- Sinny Kumari


On Nov. 23, 2013, 5:23 p.m., Siddharth Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/114055/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2013, 5:23 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> -------
> 
> Include translatoins sub-directory to CMakeLists.txt
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 25b607b 
> 
> Diff: http://git.reviewboard.kde.org/r/114055/diff/
> 
> 
> Testing
> -------
> 
> While packaging for fedora, it was not getting lang translations, post applying this patch everything worked fine.
> 
> 
> Thanks,
> 
> Siddharth Sharma
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131126/a67af847/attachment-0001.html>


More information about the Plasma-devel mailing list