Review Request 113971: improve screenlocker multiscreen handling

Aaron J. Seigo aseigo at kde.org
Fri Nov 22 22:13:16 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113971/#review44243
-----------------------------------------------------------

Ship it!


two minor issues that can be easily cleared up without further review; please push at your convenience.


ksmserver/screenlocker/greeter/greeterapp.cpp
<http://git.reviewboard.kde.org/r/113971/#comment31683>

    missing {}s



ksmserver/screenlocker/greeter/greeterapp.cpp
<http://git.reviewboard.kde.org/r/113971/#comment31684>

    what i actually meant by "add comments" was explain *why* the events need to be shared. :)


- Aaron J. Seigo


On Nov. 21, 2013, 9:14 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113971/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 9:14 p.m.)
> 
> 
> Review request for Plasma, Christoph Feck and Martin Gräßlin.
> 
> 
> Bugs: 311188
>     http://bugs.kde.org/show_bug.cgi?id=311188
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> - pass focus to greeter under the mouse
> - share keyboard events
> - let through keyboard events for one hidden locker
>   (mouse wakeup case)
> - remove double filtering
> 
> @Christoph:
> I meant a real human. A shared responsibility simply means that no one is responsible.
> 
> @Martin:
> I found the dupe and it's assigned to you. Do you feel in charge here or do you know whom to addd?
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 951b1e3 
>   ksmserver/screenlocker/greeter/greeterapp.cpp bf33945 
> 
> Diff: http://git.reviewboard.kde.org/r/113971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131122/3cae51be/attachment.html>


More information about the Plasma-devel mailing list