Review Request 113971: improve screenlocker multiscreen handling

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113971/#review44095
-----------------------------------------------------------


a couple minor things; most important is to document the code with comments so that the knowledge you gained in creating this patch is not lost on future developers.

i imagine you've also tested this with single screen, just to be certain?


ksmserver/screenlocker/greeter/greeterapp.cpp
<http://git.reviewboard.kde.org/r/113971/#comment31601>

    missing {}s



ksmserver/screenlocker/greeter/greeterapp.cpp
<http://git.reviewboard.kde.org/r/113971/#comment31604>

    why reverse this? now it says the saver is not visible if even one screen saver window is not visible; previously it would say the saver is visible if at least one was visible.



ksmserver/screenlocker/greeter/greeterapp.cpp
<http://git.reviewboard.kde.org/r/113971/#comment31605>

    a comment in the code here explaining why this is needed / why it is important would be good.


- Aaron J. Seigo


On Nov. 20, 2013, 4:52 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113971/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 4:52 p.m.)
> 
> 
> Review request for Plasma, Christoph Feck and Martin Gräßlin.
> 
> 
> Bugs: 311188
>     http://bugs.kde.org/show_bug.cgi?id=311188
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> - pass focus to greeter under the mouse
> - share keyboard events
> - let through keyboard events for one hidden locker
>   (mouse wakeup case)
> - remove double filtering
> 
> @Christoph:
> I meant a real human. A shared responsibility simply means that no one is responsible.
> 
> @Martin:
> I found the dupe and it's assigned to you. Do you feel in charge here or do you know whom to addd?
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h 951b1e3 
>   ksmserver/screenlocker/greeter/greeterapp.cpp bf33945 
> 
> Diff: http://git.reviewboard.kde.org/r/113971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131121/0e68677b/attachment-0001.html>