Review Request 113993: Remove the nowplaying dataengine

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113993/
-----------------------------------------------------------

Review request for kde-workspace and Plasma.


Repository: kde-workspace


Description
-------

Remove the nowplaying dataengine

This has been superceded by the mpris2 dataengine.


(And good riddance)


Diffs
-----

  plasma/generic/dataengines/CMakeLists.txt ee010a9 
  plasma/generic/dataengines/nowplaying/CMakeLists.txt ebb9e8e 
  plasma/generic/dataengines/nowplaying/Messages.sh eaac8ef 
  plasma/generic/dataengines/nowplaying/TODO 557902f 
  plasma/generic/dataengines/nowplaying/config-nowplaying.cmake c596066 
  plasma/generic/dataengines/nowplaying/nowplaying.operations 4a5587d 
  plasma/generic/dataengines/nowplaying/nowplayingengine.h 780233c 
  plasma/generic/dataengines/nowplaying/nowplayingengine.cpp f88d739 
  plasma/generic/dataengines/nowplaying/plasma-dataengine-nowplaying.desktop 7717082 
  plasma/generic/dataengines/nowplaying/playeractionjob.h 0cfbf1b 
  plasma/generic/dataengines/nowplaying/playeractionjob.cpp 6943c25 
  plasma/generic/dataengines/nowplaying/playercontainer.h 06360e0 
  plasma/generic/dataengines/nowplaying/playercontainer.cpp 79db747 
  plasma/generic/dataengines/nowplaying/playercontrol.h 760498d 
  plasma/generic/dataengines/nowplaying/playercontrol.cpp 7480af1 
  plasma/generic/dataengines/nowplaying/playerinterface/dbuswatcher.h 38522ef 
  plasma/generic/dataengines/nowplaying/playerinterface/dbuswatcher.cpp 3e7396a 
  plasma/generic/dataengines/nowplaying/playerinterface/juk.h 5f44618 
  plasma/generic/dataengines/nowplaying/playerinterface/juk.cpp ad3deb6 
  plasma/generic/dataengines/nowplaying/playerinterface/juk_p.h d8f672c 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris.h cb8cf83 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris.cpp 69c3c3c 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/mpris_p.h d8c3121 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/mprisdbustypes.h 325f3e4 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/mprisdbustypes.cpp 2d42a50 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.player.xml 302c383 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.root.xml aa93e4b 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris/org.freedesktop.MediaPlayer.tracklist.xml e8cb127 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2.h 0ab3650 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2.cpp fbc0689 
  plasma/generic/dataengines/nowplaying/playerinterface/mpris2/mpris2_p.h 04a3a76 
  plasma/generic/dataengines/nowplaying/playerinterface/org.kde.juk.player.xml bb6e18d 
  plasma/generic/dataengines/nowplaying/playerinterface/player.h 9c2e0fc 
  plasma/generic/dataengines/nowplaying/playerinterface/player.cpp b0f2680 
  plasma/generic/dataengines/nowplaying/playerinterface/playerfactory.h 27371f3 
  plasma/generic/dataengines/nowplaying/playerinterface/playerfactory.cpp 53c1724 
  plasma/generic/dataengines/nowplaying/playerinterface/pollingwatcher.h 34446da 
  plasma/generic/dataengines/nowplaying/playerinterface/pollingwatcher.cpp cf6bd99 
  plasma/generic/dataengines/nowplaying/playerinterface/xmms.h 8e58c73 
  plasma/generic/dataengines/nowplaying/playerinterface/xmms.cpp da3e9db 
  plasma/generic/dataengines/nowplaying/playerinterface/xmms_p.h 10a6e51 

Diff: http://git.reviewboard.kde.org/r/113993/diff/


Testing
-------

CMake still runs successfully.


Thanks,

Alex Merry

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20131121/ef2d9cf0/attachment.html>