Review Request 110629: Feature: Dimming the image when it is not viewed directly

Shantanu Tushar shantanu at kde.org
Fri May 24 16:30:46 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110629/#review33101
-----------------------------------------------------------



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/110629/#comment24463>

    there should be a newline after '{'



shells/newshell/package/contents/ui/mediacenter.qml
<http://git.reviewboard.kde.org/r/110629/#comment24464>

    missing indentation


- Shantanu Tushar


On May 24, 2013, 7:46 a.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110629/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 7:46 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Dimming the image when it is not viewed directly or more simply when it shows up in background while navigating in the Plasma Media Center.
> 
> The existing minor problem was that when user views a picture in a slideshow and then navigate to the main screen or one level up, the image is shown in the same opacity as the original in the background which causes a little discomfort in seeing the gallery and other written texts on screen.
> 
> 
> Diffs
> -----
> 
>   shells/newshell/package/contents/ui/mediacenter.qml ef71938 
> 
> Diff: http://git.reviewboard.kde.org/r/110629/diff/
> 
> 
> Testing
> -------
> 
> Works as intended.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130524/71f562f4/attachment.html>


More information about the Plasma-devel mailing list