Review Request 110604: Drag and Drop feature to remove items from playlist added.

[saurabh jain]

> On May 23, 2013, 8:59 a.m., Shantanu Tushar wrote:
> > mediaelements/playlist/PlaylistDelegate.qml, line 104
> > <http://git.reviewboard.kde.org/r/110604/diff/1/?file=145972#file145972line104>
> >
> >     can you derive the value 200 from the playlist width? You can get it using listViewItem.ListView.view.width * 0.4
> >     Experiment with values other than 0.4 to see what feels natural.
> >     Also, remove the extra whitespace

Initially I was using the comparitive value to be parent.width/3. I found this to be the best among other values as it allows the less tolerance for repositioning of item when the user might actually be trying to remove that item. If you say, should I finalize this value?


- saurabh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110604/#review33013
-----------------------------------------------------------


On May 23, 2013, 9:41 a.m., saurabh jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110604/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 9:41 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Drag and Drop feature to remove items from playlist in PMC directly without interrupting the current session of media being played. 
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/playlistmodel.h bedc26a 
>   mediaelements/playlist/PlaylistDelegate.qml 7dac484 
> 
> Diff: http://git.reviewboard.kde.org/r/110604/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> saurabh jain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130523/d0121caa/attachment.html>