Review Request 110604: Drag and Drop feature to remove items from playlist added.

[Shantanu Tushar]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110604/#review33013
-----------------------------------------------------------



mediaelements/playlist/Playlist.qml
<http://git.reviewboard.kde.org/r/110604/#comment24430>

    Is this needed? Looks like a leftover



mediaelements/playlist/PlaylistDelegate.qml
<http://git.reviewboard.kde.org/r/110604/#comment24431>

    extra whitespace, please remove.



mediaelements/playlist/PlaylistDelegate.qml
<http://git.reviewboard.kde.org/r/110604/#comment24432>

    can you derive the value 200 from the playlist width? You can get it using listViewItem.ListView.view.width * 0.4
    Experiment with values other than 0.4 to see what feels natural.
    Also, remove the extra whitespace



mediaelements/playlist/PlaylistDelegate.qml
<http://git.reviewboard.kde.org/r/110604/#comment24433>

    please use listViewItem.ListView.view.model.currentIndex instead of playlistModel. This helps in being agnostic about the model.


- Shantanu Tushar


On May 23, 2013, 8:16 a.m., saurabh jain wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110604/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 8:16 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Drag and Drop feature to remove items from playlist in PMC directly without interrupting the current session of media being played. 
> 
> 
> Diffs
> -----
> 
>   libs/mediacenter/playlistmodel.h bedc26a 
>   mediaelements/playlist/Playlist.qml bbe97a7 
>   mediaelements/playlist/PlaylistDelegate.qml 7dac484 
> 
> Diff: http://git.reviewboard.kde.org/r/110604/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> saurabh jain
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130523/03f99f79/attachment-0001.html>