Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel
Commit Hook
null at kde.org
Thu May 16 15:09:30 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110427/
-----------------------------------------------------------
(Updated May 16, 2013, 3:09 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma, Aaron J. Seigo and Marco Martin.
Description
-------
This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504).
Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup).
This addresses bug 318504.
http://bugs.kde.org/show_bug.cgi?id=318504
Diffs
-----
plasma/configloader.cpp 5c67474
plasma/tests/configloadertest.h ed5a32c
plasma/tests/configloadertest.cpp 6737cae
plasma/tests/configloadertest.xml 13ccd32
Diff: http://git.reviewboard.kde.org/r/110427/diff/
Testing
-------
Compiles, unit test passes (assuming that it was done correctly ;-)).
Thanks,
Michał Dutkiewicz
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/359ee731/attachment-0001.html>
More information about the Plasma-devel
mailing list