Review Request 110427: Allow Plasma::ConfigLoader to load default QColor values that contain alpha channel

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110427/#review32649
-----------------------------------------------------------


This review has been submitted with commit 72db566f4bf40b79aca69a31e3f514bc7c771628 by Michał Dutkiewicz to branch master.

- Commit Hook


On May 15, 2013, 2:50 p.m., Michał Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110427/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 2:50 p.m.)
> 
> 
> Review request for Plasma, Aaron J. Seigo and Marco Martin.
> 
> 
> Description
> -------
> 
> This patch aims to allow Plasma::ConfigLoader to properly load default values of QColor that contains alpha channel (bug #318504).
> Apparently constructor of QColor which takes QString as value fails to detect and properly (QColor with alpha channel is handled properly by KConfigGroup).
> 
> 
> This addresses bug 318504.
>     http://bugs.kde.org/show_bug.cgi?id=318504
> 
> 
> Diffs
> -----
> 
>   plasma/configloader.cpp 5c67474 
>   plasma/tests/configloadertest.h ed5a32c 
>   plasma/tests/configloadertest.cpp 6737cae 
>   plasma/tests/configloadertest.xml 13ccd32 
> 
> Diff: http://git.reviewboard.kde.org/r/110427/diff/
> 
> 
> Testing
> -------
> 
> Compiles, unit test passes (assuming that it was done correctly ;-)).
> 
> 
> Thanks,
> 
> Michał Dutkiewicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/e49fe48c/attachment.html>