Review Request 110453: Order tasks by activity in tasks applet

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110453/
-----------------------------------------------------------

(Updated May 16, 2013, 2:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

A new ordering strategy ActivitySortingStrategy was created. This strategy will
order elements by the activities they are available on.

The ones which are available in the activities with more tasks will be
displayed first.


Diffs
-----

  libs/taskmanager/CMakeLists.txt 375a0d6 
  libs/taskmanager/groupmanager.h f7e9878 
  libs/taskmanager/groupmanager.cpp 45c15a9 
  libs/taskmanager/strategies/activitysortingstrategy.h PRE-CREATION 
  libs/taskmanager/strategies/activitysortingstrategy.cpp PRE-CREATION 
  plasma/desktop/applets/tasks/tasks.cpp 0a86dcf 

Diff: http://git.reviewboard.kde.org/r/110453/diff/


Testing
-------

Three activities were created (called Activity 1, 2 and 3), and several dialogs were created (the activities to which each dialog were assigned are marked by the numbers after the "A" in the title).
Screenshot 1 shows the task manager running in plasma-windowed with grouping disabled, and the task manager being assigned to all activities. The second screenshot shows the task manager if the task manager is assigned only to Activity 1, an instance of xmessage is assigned to activity 2 and the grouping by program is active.


File Attachments
----------------

Screenshot 1
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img1.png
Screenshot 2
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/15/img2.png


Thanks,

José Millán Soto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/f635dc56/attachment.html>