Patch Review

[Akshay Ratan]

Hi,
    With regard to the bug :: https://bugs.kde.org/show_bug.cgi?id=319626 ,
I have submitted a patch for review. Its a very minor change as per the
idea suggestion by Shantanu. Please let me know if further changes are to
be discussed :)

I have simply removed the visible tag in the Plasma ToolButton under
PlaylistDelegate.qml file which enables the playlist to have the "remove
sign" on every song in the playlist. So now, user does not have to click on
the song and then delete it from playlist which earlier forced PMC to stop
the current media. Now the current media can be played on while
removing/deleting any "other" item in the playlist of the mediaplayer.

Cheers,
Akshay Ratan

On Mon, May 13, 2013 at 11:58 PM, Akshay Ratan <akshayratan at gmail.com>wrote:

> Hi,
>     Thanks for the review . I am sorry, i didnt really ask before
> implementing the tooltip, I believe I should have done that. Anyways, in
> that case, Should I like implement the text feature at few necessary places
> in PMC ? I should be able to do that without much difficulty I presume with
> obviously a little help if necessary from Plasma Developers.
>
> And yes, its indeed an enjoyable period for me learning QML and other
> stuff ! :) Summers would no doubt be an exciting one for me :)
>
> Cheers,
> Akshay Ratan
>
>
> On Sun, May 12, 2013 at 10:40 PM, Sinny Kumari <ksinny at gmail.com> wrote:
>
>> Hi!
>>
>> Good to see your progress :)
>>
>>  getting error since there is no item named ToolTip. Did you forget to
>> add any file like ToolTip.qml in diff ?
>>
>> One more thing, we don't want to keep tooltip in PMC, UI should be itself
>> in such a way that it shouldn't require tooltip to understand.
>> One reason for this is tooltip won't work on tablet and TV since tooltip
>> work on mouse hover.
>>
>> Instead of tooltip, we will use the idea of having text at bottom for
>> element in focus like you see in Home screen, the text description which
>> come for selected backend.
>>
>>
>>
>>
>> On Sun, May 12, 2013 at 2:31 AM, Akshay Ratan <akshayratan at gmail.com>wrote:
>>
>>> Hi,
>>>     Read and understood your previous mail very carefully. I thought to
>>> reply with a concerned patch regarding the animation problem in GridView.
>>> Anyways, as Shantanu and you suggested to study QML Animations and
>>> Transitions thoroughly, I was doing that :)
>>>
>>
>>
>> Take your time to learn. There is no hurry. Don't think like you don't
>> know much now. You will learn many things while working. I too learned in
>> the same way and still learning :)
>>
>>
>> Anyways, while going through the codebase, I thought to implement a
>>> tooltip for the Slideshow button in the Picture Gallery. Also in the
>>> PictureStrip.qml , minor code editing has been tried by me. The resultant,
>>> rather a little messy code patch is attached. Please review it ! Kompare is
>>> providing a good view of the differences :)  Its a very basic patch :( I am
>>> trying to do better by studying QML as promised thoroughly ! I should be
>>> able to master it in a few days. As Shantanu suggested, I am in a process
>>> of making a GridView based viewer and then testing for the transition
>>> smoothness in it.
>>>
>>> To be honest, its complete fun hacking on PMC :)
>>>
>>> I will CC the patch for the community review once its in a perfect shape
>>> and better after your suggestions !
>>>
>>> Thanks for the help !
>>>
>>> Cheers,
>>> Akshay Ratan
>>>
>>
>>
>>
>> --
>> http://www.sinny.in
>>
>
>
>
> --
> Akshay
>



-- 
Akshay
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/fc6cead0/attachment-0001.html>