Patch Review

[Sinny Kumari]

Cool! patch works fine :)


On Thu, May 16, 2013 at 2:17 AM, Marco Martin <notmart at gmail.com> wrote:

> On Wednesday 15 May 2013, Akshay Ratan wrote:
> > Hi,
> >     With regard to the bug ::
> https://bugs.kde.org/show_bug.cgi?id=319626 ,
> > I have submitted a patch for review. Its a very minor change as per the
> > idea suggestion by Shantanu. Please let me know if further changes are to
> > be discussed :)
> >
>
> Hi,
> first of all thanks for the patch :)
>
> one problem of putting it on bugzilla is that they risk to get forgotten.
> Since we had this problem in the past, now a new system for patches is in
> place:
> https://git.reviewboard.kde.org
>
>
+ 1


One more thing, patch attached on bugzilla contains some extra diff from
your build directory. Please fix that and then
send it on reviewboard :)

Cheers!



-- 
http://www.sinny.in
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130516/b1161861/attachment.html>