<div dir="ltr">Cool! patch works fine :)<br><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 16, 2013 at 2:17 AM, Marco Martin <span dir="ltr"><<a href="mailto:notmart@gmail.com" target="_blank">notmart@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Wednesday 15 May 2013, Akshay Ratan wrote:<br>
> Hi,<br>
> With regard to the bug :: <a href="https://bugs.kde.org/show_bug.cgi?id=319626" target="_blank">https://bugs.kde.org/show_bug.cgi?id=319626</a> ,<br>
> I have submitted a patch for review. Its a very minor change as per the<br>
> idea suggestion by Shantanu. Please let me know if further changes are to<br>
> be discussed :)<br>
><br>
<br>
</div>Hi,<br>
first of all thanks for the patch :)<br>
<br>
one problem of putting it on bugzilla is that they risk to get forgotten.<br>
Since we had this problem in the past, now a new system for patches is in<br>
place:<br>
<a href="https://git.reviewboard.kde.org" target="_blank">https://git.reviewboard.kde.org</a><br>
<br></blockquote><div><br>+ 1<br> </div><div><br></div><div>One more thing, patch attached on bugzilla contains some extra diff from your build directory. Please fix that and then<br></div><div>send it on reviewboard :)<br>
<br></div><div>Cheers!<br> <br></div><br clear="all"></div><br>-- <br><a href="http://www.sinny.in" target="_blank">http://www.sinny.in</a>
</div></div></div></div>