Review Request 110176: Change the visual appearance of the composited outline

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110176/#review31832
-----------------------------------------------------------



kwin/outline.cpp
<http://git.reviewboard.kde.org/r/110176/#comment23735>

    though not sure about this - personally liked the other variant better (also, what if there's a transparent panel on either edge?)


- Thomas Lübking


On April 26, 2013, 6 a.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110176/
> -----------------------------------------------------------
> 
> (Updated April 26, 2013, 6 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Change the visual appearance of the composited outline
> 
> Uses widgets/translucentbackground as FrameSvg item to ensure that we
> don't get a huge black square on the screen.
> 
> When bordering a screen edge we disable the border except if all edges
> are bordered. This makes a little bit more clear in the quick tiling case
> what will be the geometry.
> 
> Blur behind the outline does not work as:
> * moving the window generates artefacts
> * moved window needs to be above the outline, but outline needs to be on
>   top of everything. Elevating the moved window results in strange
>   side effects when moving the window "below" a keep above, etc.
> 
> 
> Diffs
> -----
> 
>   kwin/geometry.cpp 5a6786d 
>   kwin/outline.cpp ad3cfc0 
> 
> Diff: http://git.reviewboard.kde.org/r/110176/diff/
> 
> 
> Testing
> -------
> 
> I tried various Plasma theme elements. dialog/* and widgets/background are not useable as there are solid themes.
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130501/8494e703/attachment.html>