Review Request 109595: active-welcome plasmoid: use plasmacomponents ToolButton

Michael Bohlender michael.bohlender at gmail.com
Fri Mar 29 10:47:04 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109595/
-----------------------------------------------------------

(Updated March 29, 2013, 10:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma.


Description
-------

Replace ?mobilecomponents?.IconButton with PlasmaComponents.ToolButton

I estimated the button size. they might seem visually smaller but the surface you can hit to trigger should be about the same.

This is my fist patch to Plasma Active.
I did not subscribe to the plasma list when I first tried to submit this to reviewboard. 
So sorry for the spam if this comes through twice.


Diffs
-----

  applets/active-welcome/contents/code/welcome.qml cf49d2f 

Diff: http://git.reviewboard.kde.org/r/109595/diff/


Testing
-------

build + installed with kdesrc-build. viewed with plasmoidviewer

could not test the video playback as that didn't work before either.


Thanks,

Michael Bohlender

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130329/5c300d31/attachment-0001.html>


More information about the Plasma-devel mailing list