Review Request 109775: Open mediawiki runner links in default browser

Commit Hook null at kde.org
Fri Mar 29 10:24:53 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109775/
-----------------------------------------------------------

(Updated March 29, 2013, 10:24 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Richard Moore and Sebastian Kügler.


Description
-------

Use KToolInvocation::invokeBrowser to open links. This opens in the users default browser instead of konqueror.

Advantages: faster, opens in default browser
Disadvantages: only works with html (otherwise use KRun), deprecated for Qt5 use QDesktopServices::openUrl(url)


Diffs
-----

  runners/mediawiki/mediawikirunner.cpp 0b6c718 

Diff: http://git.reviewboard.kde.org/r/109775/diff/


Testing
-------

Tested with wikipedia using rekonq and chrome.
Articles open 'much' faster.


Thanks,

Maarten De Meyer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130329/d43865b9/attachment.html>


More information about the Plasma-devel mailing list