Review Request 109433: Zero size pager in default panel layout when in panel

Ralf Jung post at ralfj.de
Tue Mar 12 10:53:44 UTC 2013


Hi,

thanks a lot, I can confirm it's working here :)
(I did not test the update script though)

Kind regards,
Ralf

On 12/03/13 11:29, Commit Hook wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109433/#review29063
> -----------------------------------------------------------
> 
> 
> This review has been submitted with commit b6faef2fac5e0e715fdc1018c6a0eb7d859bff73 by Aaron Seigo to branch KDE/4.10.
> 
> - Commit Hook
> 
> 
> On March 12, 2013, 10:29 a.m., Aaron J. Seigo wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/109433/
>> -----------------------------------------------------------
>>
>> (Updated March 12, 2013, 10:29 a.m.)
>>
>>
>> Review request for Plasma and Mark Gaiser.
>>
>>
>> Description
>> -------
>>
>> Fixes zero size pager in default panel, makes it optional via a non-GUI config option which is set in the default panel layout script.
>>
>> One thing that still needs work with this is that existing installations will suddenly have pagers that show up with 1 virtual desktop. An update script needs to be written for this before it can be pushed.
>>
>>
>> Diffs
>> -----
>>
>>   plasma/desktop/applets/pager/pager.h 764cb01 
>>   plasma/desktop/applets/pager/pager.cpp 228af8e 
>>   plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js afd1f2c 
>>
>> Diff: http://git.reviewboard.kde.org/r/109433/diff/
>>
>>
>> Testing
>> -------
>>
>> None yet; just wanted to sketch out the proposed solution.
>>
>>
>> Thanks,
>>
>> Aaron J. Seigo
>>
>>
> 
> 
> 
> 
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
> 


More information about the Plasma-devel mailing list