Review Request 106110: Make autohide panel do not intercept events in fullscreen app

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106110/#review29028
-----------------------------------------------------------



plasma/desktop/shell/panelview.cpp
<http://git.reviewboard.kde.org/r/106110/#comment21715>

    I recently implemented something similar in KWin for the screenedges. If you want to have a look at it: kwin/screenedges.cpp line 329
    
    Given my impelementation the check here is not enough as it does not consider multi screens.
    
    In general I do agree that the change should be done to be consistent with KWin's implementation which we will have anyway once screen edges are merged into a deamon.


- Martin Gräßlin


On Aug. 22, 2012, 8:44 p.m., Alexey Shmalko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106110/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2012, 8:44 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Make autohide panel do not intercept events in fullscreen app.
> 
> I changed PanelView::shouldHintHide() to return true if current active application is in fullscreen mode. So in fullscreen applications panel will be always hidden.
> 
> 
> This addresses bugs 297920 and 305497.
>     http://bugs.kde.org/show_bug.cgi?id=297920
>     http://bugs.kde.org/show_bug.cgi?id=305497
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/shell/panelview.cpp 7713740 
> 
> Diff: http://git.reviewboard.kde.org/r/106110/diff/
> 
> 
> Testing
> -------
> 
> Tested with patched gentoo ebuild. Works fine.
> 
> 
> Thanks,
> 
> Alexey Shmalko
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130311/b5c30984/attachment.html>