Review Request 109340: Use default background colours for the konsolepreviewer

[Tianyu Zhu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/
-----------------------------------------------------------

(Updated March 11, 2013, 1:31 p.m.)


Review request for Plasma.


Changes
-------

Use QTextEdit instead of KTextEdit, since its background colour makes text more visible on light and dark themes when read-only is enabled.


Description
-------

- Deleted lines hard-coding the background of the konsolepreviwer to white.


This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274


Diffs (updated)
-----

  plasmate/konsole/konsolepreviewer.h 543ff77 
  plasmate/konsole/konsolepreviewer.cpp 05d426e 

Diff: http://git.reviewboard.kde.org/r/109340/diff/


Testing
-------

Tested on Kubuntu 12.10 with KDE 4.10.1
Tested with both the default and Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up well against its background.


Thanks,

Tianyu Zhu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130311/f3d66716/attachment.html>