Review Request 109340: Use default background colours for the konsolepreviewer

[Giorgos Tsiapaliokas]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109340/#review28948
-----------------------------------------------------------



plasmate/konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/109340/#comment21647>

    this code is correct, the background
    color shouldn't be hardcoded.
    
    But the konsolewidget isn't very readable without it.
    http://paste.opensuse.org/30220251
    
    The best solution is 
    * to remove the hardcoded
    background 
    * s/KTextEdit/QTextEdit
    
    QTextEdit is white in light themes and darker on the black ones
    


- Giorgos Tsiapaliokas


On March 7, 2013, 3:30 p.m., Tianyu Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109340/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 3:30 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> - Deleted lines hard-coding the background of the konsolepreviwer to white.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274
> 
> 
> Diffs
> -----
> 
>   plasmate/konsole/konsolepreviewer.cpp 05d426e 
> 
> Diff: http://git.reviewboard.kde.org/r/109340/diff/
> 
> 
> Testing
> -------
> 
> Tested on Kubuntu 12.10 with KDE 4.10.1
> Tested with both the default and Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up well against its background.
> 
> 
> Thanks,
> 
> Tianyu Zhu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130311/cb8c76f1/attachment.html>