Review Request 111047: Handle edge cases when going back/escape

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/#review34721
-----------------------------------------------------------


New patch is braking again back/esc.
Steps to reproduce:
- Launch PMC and open any video from All videos
- go back to homescreen and click in empty space.
- Now, again go back to homescreen
- Open again All videos and try esc/back. It won't work

I don't see any significance of initializing mediabrowser on clicking in empty space in homescreen. Whatever I mentioned in my last comment still doesn't work.

- Sinny Kumari


On June 19, 2013, 6 p.m., Shantanu Tushar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111047/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 6 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan and Sinny Kumari.
> 
> 
> Description
> -------
> 
> At places we assume that there always be a valid browsing backend. In many situations this isn't true, which is exactly what this patch handles.
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediabrowser/MediaBrowser.qml e7aa109 
>   shells/newshell/package/contents/ui/mediacenter.qml d533b60 
> 
> Diff: http://git.reviewboard.kde.org/r/111047/diff/
> 
> 
> Testing
> -------
> 
> Tested some scenarios that I could think of. Please test few scenarios and see if this works.
> Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine.
> 
> 
> Thanks,
> 
> Shantanu Tushar
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130620/8ce455b4/attachment.html>