Review Request 111047: Handle edge cases when going back/escape
Shantanu Tushar
shantanu at kde.org
Wed Jun 19 18:00:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111047/
-----------------------------------------------------------
(Updated June 19, 2013, 6 p.m.)
Review request for Plasma, Akshay Ratan and Sinny Kumari.
Changes
-------
Now when you click on empty space, media browser will be initialized. However, pressing escape will still directly take you to home screen. You can get the media browser by clicking on the browser button at the top.
Description
-------
At places we assume that there always be a valid browsing backend. In many situations this isn't true, which is exactly what this patch handles.
Diffs (updated)
-----
mediaelements/mediabrowser/MediaBrowser.qml e7aa109
shells/newshell/package/contents/ui/mediacenter.qml d533b60
Diff: http://git.reviewboard.kde.org/r/111047/diff/
Testing
-------
Tested some scenarios that I could think of. Please test few scenarios and see if this works.
Akshay: I think the new if conditions make previousBackend necessary, please check that your feature still works fine.
Thanks,
Shantanu Tushar
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130619/7ae6468d/attachment.html>
More information about the Plasma-devel
mailing list