Review Request 110941: Fix battery status in battery monitor plasmoid

[Alberto Villa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110941/
-----------------------------------------------------------

(Updated June 10, 2013, 7:05 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Description
-------

Battery monitor sets "batteries.cumulativePluggedin" true when "batteries.count" is greater than 0, but it's not a solid way to determine it. At least on FreeBSD, there is the possibility that a battery is always listed, even when not plugged in; this keeps the plasmoid from reacting on battery removal. The solution is to check that at least one battery is plugged in prior to enabling that property.

This is probably due to the way Solid creates the batteries in the dataengine, still the patch is an improvement over the current behaviour, in my opinion.


Diffs
-----

  plasma/generic/applets/batterymonitor/contents/code/logic.js 974694a 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml a5e1c13 

Diff: http://git.reviewboard.kde.org/r/110941/diff/


Testing
-------

Tested on FreeBSD 10, confirming the behaviour using some console.log().


Thanks,

Alberto Villa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130610/1895bc93/attachment.html>