Review Request 110776: Bug 317451 Fix : A way to return to media from main screen

[Sinny Kumari]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110776/#review33580
-----------------------------------------------------------


One issue I see after applying this patch:
When no media is getting played and if I try to click header or footer section of homescreen, empty screen gets open. 
Way to reproduce:
- open new PMC and click in header or footer, or
- browse inside PMC and return back to home without playing any media and then click in header or footer section

Other than that, one suggestion from my side. It may not be much convincing:
Instead of adding MouseArea to header and footer section of homscreen, MouseArea should be added in whole homescreen.
Advantage:
User don't need to go to header and footer section to click. Results can be achieved on clicking at any of empty space.

I tried this and it was working fine.

Rest is fine :)

- Sinny Kumari


On June 2, 2013, 8:01 a.m., Akshay Ratan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110776/
> -----------------------------------------------------------
> 
> (Updated June 2, 2013, 8:01 a.m.)
> 
> 
> Review request for Plasma, Shantanu Tushar and Sinny Kumari.
> 
> 
> Description
> -------
> 
> Clicking on the Empty top and bottom spaces of the Plasma Media Center's Homescreen takes the user back to the media being played--Video or Slideshow.
> 
> When user is viewing the pictures and comes on the main screen of the PMC, now when he/she clicks the empty welcome screen , directly slideshow appears as intended.
> 
> Same is the case with videos.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=317451.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=317451
> 
> 
> Diffs
> -----
> 
>   mediaelements/mediabrowser/MediaBrowser.qml d978285 
>   mediaelements/mediawelcome/MediaWelcome.qml c524582 
>   shells/newshell/package/contents/ui/mediacenter.qml b4a659a 
> 
> Diff: http://git.reviewboard.kde.org/r/110776/diff/
> 
> 
> Testing
> -------
> 
> Yes, works as intended.
> 
> Please check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere.
> 
> 
> Thanks,
> 
> Akshay Ratan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130602/6b1a1ac0/attachment-0001.html>