<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110776/">http://git.reviewboard.kde.org/r/110776/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One issue I see after applying this patch:
When no media is getting played and if I try to click header or footer section of homescreen, empty screen gets open.
Way to reproduce:
- open new PMC and click in header or footer, or
- browse inside PMC and return back to home without playing any media and then click in header or footer section
Other than that, one suggestion from my side. It may not be much convincing:
Instead of adding MouseArea to header and footer section of homscreen, MouseArea should be added in whole homescreen.
Advantage:
User don't need to go to header and footer section to click. Results can be achieved on clicking at any of empty space.
I tried this and it was working fine.
Rest is fine :)</pre>
<br />
<p>- Sinny</p>
<br />
<p>On June 2nd, 2013, 8:01 a.m. UTC, Akshay Ratan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Shantanu Tushar and Sinny Kumari.</div>
<div>By Akshay Ratan.</div>
<p style="color: grey;"><i>Updated June 2, 2013, 8:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Clicking on the Empty top and bottom spaces of the Plasma Media Center's Homescreen takes the user back to the media being played--Video or Slideshow.
When user is viewing the pictures and comes on the main screen of the PMC, now when he/she clicks the empty welcome screen , directly slideshow appears as intended.
Same is the case with videos.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, works as intended.
Please check for the Escape key navigation to see if it does not break the keyboard navigation flow somewhere.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=317451">https://bugs.kde.org/show_bug.cgi?id=317451</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mediaelements/mediabrowser/MediaBrowser.qml <span style="color: grey">(d978285)</span></li>
<li>mediaelements/mediawelcome/MediaWelcome.qml <span style="color: grey">(c524582)</span></li>
<li>shells/newshell/package/contents/ui/mediacenter.qml <span style="color: grey">(b4a659a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110776/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>