Review Request 111618: Fix launcher regression, only show icons instead of icons + text

Mark Gaiser markg85 at gmail.com
Mon Jul 29 21:25:12 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111618/
-----------------------------------------------------------

(Updated July 29, 2013, 9:25 p.m.)


Status
------

This change has been discarded.


Review request for Plasma and Eike Hein.


Description
-------

As described in the bug report, the launcher regressed with the move to the QML based tasks. I did my best to correct the launcher regression. The attachment shows how the launchers look with this patch.


This addresses bug 321128.
    http://bugs.kde.org/show_bug.cgi?id=321128


Diffs
-----

  plasma/desktop/applets/tasks/package/contents/code/layout.js cb7a1c2 
  plasma/desktop/applets/tasks/package/contents/ui/Task.qml 70267fb 

Diff: http://git.reviewboard.kde.org/r/111618/diff/


Testing
-------

Tested it and works just like it used to work in KDE 4.10.


File Attachments
----------------


  http://git.reviewboard.kde.org/media/uploaded/files/2013/07/20/fix_launcher.png


Thanks,

Mark Gaiser

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130729/e67063e0/attachment.html>


More information about the Plasma-devel mailing list