Review Request 111618: Fix launcher regression, only show icons instead of icons + text

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111618/#review36230
-----------------------------------------------------------


I'm sorry, but that approach is not good enough. The problem with the small launcher items is that it throws the assumption out the door that all items are of the same width, which has far-ranging consequences throughout the entire layout code: Calculating how many items to show per row in multi-row layouts, calculating at which point the taskbar is considered "full" to control opportunistic grouping and row overflow, calculating the size hints to make opportunistically growing panels work correctly, and so on. It makes the layout problem non-deterministic.

This is also why the old taskbar is actually spectacularly broken on launcher items: Try some launchers together with a two-row layout and marvel at the fallout.

I'm still working on a proper solution.

- Eike Hein


On July 20, 2013, 2:58 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111618/
> -----------------------------------------------------------
> 
> (Updated July 20, 2013, 2:58 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Description
> -------
> 
> As described in the bug report, the launcher regressed with the move to the QML based tasks. I did my best to correct the launcher regression. The attachment shows how the launchers look with this patch.
> 
> 
> This addresses bug 321128.
>     http://bugs.kde.org/show_bug.cgi?id=321128
> 
> 
> Diffs
> -----
> 
>   plasma/desktop/applets/tasks/package/contents/code/layout.js cb7a1c2 
>   plasma/desktop/applets/tasks/package/contents/ui/Task.qml 70267fb 
> 
> Diff: http://git.reviewboard.kde.org/r/111618/diff/
> 
> 
> Testing
> -------
> 
> Tested it and works just like it used to work in KDE 4.10.
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/07/20/fix_launcher.png
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130721/c9186738/attachment.html>