Review Request 108438: Use translucent/dialogs/background elements where possible

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108438/
-----------------------------------------------------------

(Updated Jan. 30, 2013, 8:25 a.m.)


Review request for kwin, Plasma, Sebastian Kügler, and Xuetian Weng.


Changes
-------

* added check that theme contains translucent element
* added Effect Feature Blur to check whether the translucent element may be used at all


Description (updated)
-------

Use translucent/dialogs/background elements where possible

In effects it's obvious that compositing is enabled, so specifying the
translucent element is no problem.

In tabbox a context property "compositing" is injected which decides
whether "translucent" or "opaque" elements should be used. Here the
translucent elements are only used if the Blur effect is available - for
this a new Effect::Feature Blur is introduced and in addition it is
tested whether the theme provides the translucent element.

Also the masking is adjusted to ensure that only the shadow is not
blurred.

Reason for this change is that Plasma theme seems not always to pick up
whether compositing is used when used from inside KWin. It does not cover
the Desktop Change OSD which uses PlasmaCore.Dialog and there we cannot
(yet) inject that we use compositing.

Overall I'm quite unhappy with this patch and I do hope we can fix it in
the proper place in the lifetime of 4.10 and revert this patch.

CCBUG: 311995
REVIEW: 108438


Diffs (updated)
-----

  kwin/effects/blur/blur.h a3820856a8db49b805ddbb2a319b8f7609dcba81 
  kwin/effects/desktopgrid/desktopgrid.cpp 53532ccff72d2a1f303265a898fd7b1fc7ea35a6 
  kwin/effects/presentwindows/presentwindows.cpp ff53aefea1b2722aea7f6c47b345c6d78e855339 
  kwin/libkwineffects/kwineffects.h 6aea85d20772a8a69855b81ef687b91dc93b98ac 
  kwin/tabbox/declarative.cpp b4d615178a0e0b8b633626a1813dfa7065515b97 
  kwin/tabbox/qml/CMakeLists.txt bda7d8b95ed3b4fb4093c9960f940a0d678710f8 
  kwin/tabbox/qml/ShadowedSvgItem.qml 87de733bf0fa1ad19d4d9203de6c6fc3548ff57f 
  kwin/tabbox/qml/clients/big_icons/contents/ui/main.qml 4a3666d2befe0010f7d9b7d4414853e8c92a92a1 
  kwin/tabbox/qml/clients/compact/contents/ui/main.qml 2bf04a50cfc8540efbc86d64bf1f6de28e63d230 
  kwin/tabbox/qml/clients/informative/contents/ui/main.qml 5e3f9a6f2ad76e7eeb7ee1e51d42e0c891b762ec 
  kwin/tabbox/qml/clients/present_windows/contents/ui/main.qml e539c8970acff701b92bdaaf816a40ccba94e4b8 
  kwin/tabbox/qml/clients/small_icons/contents/ui/main.qml 0c9b4f7f7df52f8a629d0c847185db38aa9f2c26 
  kwin/tabbox/qml/clients/text/contents/ui/main.qml ccae17d96b231269a7d8ec0ecc20b0ee69453d09 
  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml 4c33703d54c84fd54da94f821234e4cbd9c1c001 
  kwin/tabbox/qml/desktop.qml e8203b6004a321fcc5ae6d10347fdbb7144662a7 

Diff: http://git.reviewboard.kde.org/r/108438/diff/


Testing (updated)
-------

* XRender -> opaque element
* OpenGL with blur -> translucent element
* non-default theme -> normal element


Thanks,

Martin Gräßlin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130130/1ab4b84a/attachment.html>