Review Request 108223: use Plasma::Dialog for kmix osd

Sebastian Kügler sebas at kde.org
Wed Jan 16 12:35:44 UTC 2013


On Tuesday, January 15, 2013 19:43:32 Christian Esken wrote:
> I did not expect that this patched would be pushed into KDE4.10, as we are
> past release candidate 2 already. Is this really well tested, especially
> with theme changes, font changes and so on?

My emails say, that it's only gone into master.

On the other hand, we had plenty of such patches, and they didn't cause any 
problem. So even if this patch hasn't been tested for all corner cases (it 
should have been!), very similar patches have, so the risk seems manageable.
-- 
sebas

http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9


More information about the Plasma-devel mailing list