Review Request 108223: use Plasma::Dialog for kmix osd

[Christian Esken]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108223/#review25606
-----------------------------------------------------------


I did not expect that this patched would be pushed into KDE4.10, as we are past release candidate 2 already. Is this really well tested, especially with theme changes, font changes and so on?

- Christian Esken


On Jan. 6, 2013, 11:52 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108223/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2013, 11:52 p.m.)
> 
> 
> Review request for Plasma, Solid, Aaron J. Seigo, Kai Uwe Broulik, and Christian Esken.
> 
> 
> Description
> -------
> 
> Similiar to https://git.reviewboard.kde.org/r/108222, this would fix the shadow problem for kmix osd.
> 
> 
> Diffs
> -----
> 
>   gui/osdwidget.h 9ec0100 
>   gui/osdwidget.cpp 2dc202e 
> 
> Diff: http://git.reviewboard.kde.org/r/108223/diff/
> 
> 
> Testing
> -------
> 
> localily tested, no problem
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130115/107a8775/attachment.html>