Review Request 108400: Improve highlighted contrast in thumbnail tabbox

[Thomas Lübking]

> On Jan. 15, 2013, 3:06 p.m., Aaron J. Seigo wrote:
> > yes, looks proper.
> > 
> > on a broader note, it's probably hard/impossible to make the viewitem svg work for this use case and the general use case of QML views .. so +1 from me.

I'd rather say if theme can not provide this, the indication has to happen theme agnostic, eg.:

            KWin.ThumbnailItem {
                property variant data: model
                id: thumbnailItem
                wId: windowId
                anchors {
                    fill: parent
                    property int padding: thumbnailListView.currentIndex == index ? 0 : Math.min(parent.width, parent.height)/4
                    leftMargin: hoverItem.margins.left + padding
                    rightMargin: hoverItem.margins.right + padding
                    topMargin: hoverItem.margins.top + padding
                    bottomMargin: hoverItem.margins.bottom + padding
                }
            }


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108400/#review25584
-----------------------------------------------------------


On Jan. 14, 2013, 8:08 a.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108400/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2013, 8:08 a.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Improve highlighted contrast in thumbnail tabbox
> 
> Air's hovered svg provides only a thin frame around the borders, too
> little to quickly spot the highlighted item when the whole widget is
> only around for a few milliseconds (as is usual with the tabbox).
> 
> This patch paints a rectangle with rounded corners behind the
> highlighted item instead, making it much easier to spot the currently
> highlighted item.
> 
> Aimed for master and KDE/4.10.
> 
> 
> Diffs
> -----
> 
>   kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml 4c33703d54c84fd54da94f821234e4cbd9c1c001 
> 
> Diff: http://git.reviewboard.kde.org/r/108400/diff/
> 
> 
> Testing
> -------
> 
> Tested with Air, Oxygen and Slim Glow, all work as expected, all show contrast improvements, while still looking beautiful. :)
> 
> 
> File Attachments
> ----------------
> 
> before, try spotting the highlighted item
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-before.png
>  after, much easier to find
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-after.png
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130115/af055c9e/attachment-0001.html>