Review Request 108400: Improve highlighted contrast in thumbnail tabbox

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108400/
-----------------------------------------------------------

(Updated Jan. 14, 2013, 9:08 a.m.)


Review request for kwin and Plasma.


Changes
-------

adding plasma as I would like to get some feedback on whether highlight is the right element to use in general or whether we should migrate away from it as it seems to be unusable with the default theme for our uses.


Description
-------

Improve highlighted contrast in thumbnail tabbox

Air's hovered svg provides only a thin frame around the borders, too
little to quickly spot the highlighted item when the whole widget is
only around for a few milliseconds (as is usual with the tabbox).

This patch paints a rectangle with rounded corners behind the
highlighted item instead, making it much easier to spot the currently
highlighted item.

Aimed for master and KDE/4.10.


Diffs
-----

  kwin/tabbox/qml/clients/thumbnails/contents/ui/main.qml 4c33703d54c84fd54da94f821234e4cbd9c1c001 

Diff: http://git.reviewboard.kde.org/r/108400/diff/


Testing
-------

Tested with Air, Oxygen and Slim Glow, all work as expected, all show contrast improvements, while still looking beautiful. :)


File Attachments
----------------

before, try spotting the highlighted item
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-before.png
 after, much easier to find
  http://git.reviewboard.kde.org/media/uploaded/files/2013/01/14/kwin-tabbox-contrast-after.png


Thanks,

Sebastian Kügler

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130114/81f69a5d/attachment.html>