Review Request: Show album art in krunner results.

[Emil Sedgh]

> On Jan. 10, 2013, 10:09 p.m., Aaron J. Seigo wrote:
> > very nice idea.
> > 
> > as for the QPixmap error, one option is to do all the pixmap handling in the GUI thread by creating an object in the GUI thread and communicating with it via slots. the Places runner (kde-workspace/plasma/generic/runners/places) does this using the PlacesRunnerHelper class. it's pretty ugly, though, and should be avoided if possible (it really destroys the benefit of using threads, after all :) is it the QIcon line that triggers these errors? or are they there even with that?
> 
> Emil Sedgh wrote:
>     Those warnings go away if I checkout my changes. So yeah, I'm pretty sure using QIcon causes them.
>     However, it seems that they are quite harmless. The runner works fast and fine.
>     
>     Do you think I should do the same as places runner?

I just found out that many runners already throw this warning.
Including Youtube runner, Contacts runner and probably Telepathy runner.

Ideas? This seems pretty harmless.


- Emil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108316/#review25195
-----------------------------------------------------------


On Jan. 11, 2013, 7:01 a.m., Emil Sedgh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108316/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2013, 7:01 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Audio player controller has the ability to search through Amarok's collection.
> This patch uses 'arturl' property of Amarok's reply to show album art in KRunner results.
> 
> Some considerations:
> arturl sent by Amarok has file:// prefix which QIcon does not understand. I used QString::remove(0,7) to remove the prefix but it seems hackish. Are there better ways of fixing this issue?
> I get many warnings when I run krunner: "QPixmap: It is not safe to use pixmaps outside the GUI thread". How should I fix it?
> 
> 
> Diffs
> -----
> 
>   runners/audioplayercontrol/audioplayercontrolrunner.cpp 75afb75 
> 
> Diff: http://git.reviewboard.kde.org/r/108316/diff/
> 
> 
> Testing
> -------
> 
> Works fine if there's some album art.
> Reverts to audio-x-generic icon if no arturl is defined.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/108316/s/1013/
> 
> 
> Thanks,
> 
> Emil Sedgh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130111/7e2e91dc/attachment-0001.html>