<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108316/">http://git.reviewboard.kde.org/r/108316/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 10th, 2013, 10:09 p.m., <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">very nice idea.
as for the QPixmap error, one option is to do all the pixmap handling in the GUI thread by creating an object in the GUI thread and communicating with it via slots. the Places runner (kde-workspace/plasma/generic/runners/places) does this using the PlacesRunnerHelper class. it's pretty ugly, though, and should be avoided if possible (it really destroys the benefit of using threads, after all :) is it the QIcon line that triggers these errors? or are they there even with that?</pre>
</blockquote>
<p>On January 11th, 2013, 7 a.m., <b>Emil Sedgh</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Those warnings go away if I checkout my changes. So yeah, I'm pretty sure using QIcon causes them.
However, it seems that they are quite harmless. The runner works fast and fine.
Do you think I should do the same as places runner?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just found out that many runners already throw this warning.
Including Youtube runner, Contacts runner and probably Telepathy runner.
Ideas? This seems pretty harmless.</pre>
<br />
<p>- Emil</p>
<br />
<p>On January 11th, 2013, 7:01 a.m., Emil Sedgh wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Emil Sedgh.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2013, 7:01 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Audio player controller has the ability to search through Amarok's collection.
This patch uses 'arturl' property of Amarok's reply to show album art in KRunner results.
Some considerations:
arturl sent by Amarok has file:// prefix which QIcon does not understand. I used QString::remove(0,7) to remove the prefix but it seems hackish. Are there better ways of fixing this issue?
I get many warnings when I run krunner: "QPixmap: It is not safe to use pixmaps outside the GUI thread". How should I fix it?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works fine if there's some album art.
Reverts to audio-x-generic icon if no arturl is defined.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/audioplayercontrol/audioplayercontrolrunner.cpp <span style="color: grey">(75afb75)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108316/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/108316/s/1013/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2013/01/10/bg13_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>