Review Request: fix layout, resize for pager plasmoid

Xuetian Weng wengxt at gmail.com
Thu Jan 10 18:05:40 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108329/
-----------------------------------------------------------

(Updated Jan. 10, 2013, 6:05 p.m.)


Review request for Plasma and Luís Gabriel Lima.


Description (updated)
-------

1. remove some call to setMinimumSize. set minimum size to preferredSize will cause the minimumSize to be the size after plasma launches, which means if you put pager on desktop, it cannot be resize to smaller size.
2. call layout->activate() to trigger rearrangement immediately in updateSizes, this will fix that DeclarativeWidget initial size/position problem.
3. remove some duplicated code (duplicated call to update, etc)
4. fix window position in pager.
|-----------|
||---------||
||         ||
||---------||
|-----------|

Pager has 1 pixel smaller rect for the real display region, so all child inside this clip rect would have 1 extra pixel for position calculation, the x and y of child window rect should minus 1 first.


This addresses bug 306414.
    http://bugs.kde.org/show_bug.cgi?id=306414


Diffs
-----

  plasma/desktop/applets/pager/package/contents/ui/main.qml c3cee23 
  plasma/desktop/applets/pager/pager.cpp a3c4277 

Diff: http://git.reviewboard.kde.org/r/108329/diff/


Testing
-------

all problem mentioned are resolved.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130110/c0a31191/attachment.html>


More information about the Plasma-devel mailing list