<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108329/">http://git.reviewboard.kde.org/r/108329/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma and Luís Gabriel Lima.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Jan. 10, 2013, 6:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. remove some call to setMinimumSize. set minimum size to preferredSize will cause the minimumSize to be the size after plasma launches, which means if you put pager on desktop, it cannot be resize to smaller size.
2. call layout->activate() to trigger rearrangement immediately in updateSizes, this will fix that DeclarativeWidget initial size/position problem.
3. remove some duplicated code (duplicated call to update, etc)
4. fix window position in pager.
|-----------|
||---------||
|| ||
||---------||
|-----------|
Pager has 1 pixel smaller rect for the real display region, so all child inside this clip rect would have 1 extra pixel for position calculation, the x and y of child window rect should minus 1 first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">all problem mentioned are resolved.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=306414">306414</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/desktop/applets/pager/package/contents/ui/main.qml <span style="color: grey">(c3cee23)</span></li>
<li>plasma/desktop/applets/pager/pager.cpp <span style="color: grey">(a3c4277)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108329/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>