Review Request: port kdelib's tooltip shadow code to icontasks, and remove halo
Commit Hook
null at kde.org
Wed Jan 9 14:34:05 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108265/#review25066
-----------------------------------------------------------
This review has been submitted with commit 94d36fbb721c39becd5db9cfff42cf148a6cae80 by Weng Xuetian to branch KDE/4.10.
- Commit Hook
On Jan. 8, 2013, 2:06 p.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108265/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 2:06 p.m.)
>
>
> Review request for Plasma, Cedric Bellegarde and Aaron J. Seigo.
>
>
> Description
> -------
>
> copy dialogshadows to icontasks, and use DialogShadows to handle icon tasks shadow.
>
> This is a different solution of https://git.reviewboard.kde.org/r/108241/ , I guess this is what it should be.
>
> (remove halo part is just to keep consistency with default tooltip)
>
>
> Diffs
> -----
>
> applets/icontasks/CMakeLists.txt 1ff6042
> applets/icontasks/tooltips/dialogshadows.cpp PRE-CREATION
> applets/icontasks/tooltips/dialogshadows_p.h PRE-CREATION
> applets/icontasks/tooltips/tooltip.cpp 43f09ed
> applets/icontasks/tooltips/tooltipmanager.cpp dd36a9e
> applets/icontasks/tooltips/windowpreview.cpp 94c9eb2
>
> Diff: http://git.reviewboard.kde.org/r/108265/diff/
>
>
> Testing
> -------
>
> tested, no problem.
>
>
> Thanks,
>
> Xuetian Weng
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130109/444e7b79/attachment.html>
More information about the Plasma-devel
mailing list