Review Request: fix random battery cumulative data error update upon resume

Xuetian Weng wengxt at gmail.com
Tue Jan 8 22:29:00 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108280/
-----------------------------------------------------------

Review request for Plasma, Viranch Mehta and Viranch Mehta.


Description
-------

in some case, slot connect to dataChanged signal might see wrong data in data model, so update Cumulative data upon dataChanged signal for model, this would fix random "fake unavailable" battery upon resume.


This addresses bug 306952.
    http://bugs.kde.org/show_bug.cgi?id=306952


Diffs
-----

  plasma/generic/applets/batterymonitor/contents/code/logic.js 7047789 
  plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml 035141d 

Diff: http://git.reviewboard.kde.org/r/108280/diff/


Testing
-------

due the problem is "so" random, that I can only say it seems to be fixed. At least this change doesn't do any harm and will reduce useless updateCumulative call.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130108/b6a8d040/attachment.html>


More information about the Plasma-devel mailing list