Review Request: Rename krunner plugin konsolesessions to konsoleprofiles

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107881/#review24884
-----------------------------------------------------------


i can understand changing the visible name, but why change the plugin name and the rest of it? that's an implementation detail, and while the name used may be technically "wrong" it is both a smaller change as well as a safer change to leave them as-is. each kconfig update script is something that needs to be processed at runtime, which must be present to provide an upgrade path, etc.

so imo only the user visible strings should be altered and the reset should remain as-is.

- Aaron J. Seigo


On Dec. 31, 2012, 6:58 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107881/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2012, 6:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions. 
> 
> Also, the equivalent plasmoid is properly named as "konsole profiles". 
> 
> 
> Diffs
> -----
> 
>   runners/CMakeLists.txt bb4b491 
>   runners/konsoleprofiles/CMakeLists.txt PRE-CREATION 
>   runners/konsoleprofiles/Messages.sh PRE-CREATION 
>   runners/konsoleprofiles/konsoleprofiles.cpp PRE-CREATION 
>   runners/konsoleprofiles/konsoleprofiles.desktop PRE-CREATION 
>   runners/konsoleprofiles/konsoleprofiles.h PRE-CREATION 
>   runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd PRE-CREATION 
>   runners/konsolesessions/CMakeLists.txt c1d5cea 
>   runners/konsolesessions/Messages.sh 5f03904 
>   runners/konsolesessions/konsolesessions.cpp ed7550a 
>   runners/konsolesessions/konsolesessions.desktop 7d9ce5a 
>   runners/konsolesessions/konsolesessions.h a98c253 
> 
> Diff: http://git.reviewboard.kde.org/r/107881/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130107/47f18f35/attachment-0001.html>