<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107881/">http://git.reviewboard.kde.org/r/107881/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i can understand changing the visible name, but why change the plugin name and the rest of it? that's an implementation detail, and while the name used may be technically "wrong" it is both a smaller change as well as a safer change to leave them as-is. each kconfig update script is something that needs to be processed at runtime, which must be present to provide an upgrade path, etc.
so imo only the user visible strings should be altered and the reset should remain as-is.</pre>
<br />
<p>- Aaron J.</p>
<br />
<p>On December 31st, 2012, 6:58 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Dec. 31, 2012, 6:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Konsole currently does not provide the session feature like in kate and konqueror. That plugin works with konsole profiles, not the not-reimplemented-yet konsole sessions.
Also, the equivalent plasmoid is properly named as "konsole profiles". </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>runners/CMakeLists.txt <span style="color: grey">(bb4b491)</span></li>
<li>runners/konsoleprofiles/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsoleprofiles.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsoleprofiles/konsolesessions_renamed_to_konsoleprofiles.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>runners/konsolesessions/CMakeLists.txt <span style="color: grey">(c1d5cea)</span></li>
<li>runners/konsolesessions/Messages.sh <span style="color: grey">(5f03904)</span></li>
<li>runners/konsolesessions/konsolesessions.cpp <span style="color: grey">(ed7550a)</span></li>
<li>runners/konsolesessions/konsolesessions.desktop <span style="color: grey">(7d9ce5a)</span></li>
<li>runners/konsolesessions/konsolesessions.h <span style="color: grey">(a98c253)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107881/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>