Review Request 109160: do not truncate list of help options in KRunner

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109160/#review28131
-----------------------------------------------------------


the way  help is shown needs to be improved in general. i'd really prefer not to have further changes in the qgraphicsview based krunner UI, however, unlesls there is very very good reason for it (as it will simply make life with the qml port harder)


krunner/interfaces/default/resultscene.cpp
<http://git.reviewboard.kde.org/r/109160/#comment21045>

    it m_items is not empty, but it also is not the same size as maxItemsAllowed, it should be adjusted.
    


- Aaron J. Seigo


On Feb. 25, 2013, 11:35 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109160/
> -----------------------------------------------------------
> 
> (Updated Feb. 25, 2013, 11:35 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> Show all help options
> 
> KRunner's resultview limits the numer of items shown to 50. This makes
> sense when showing runner results, but it also cuts off the list of help
> options, making it incomplete.
> 
> Suggested patch adds a parameter to ResultScene::setQueryMatches(...)
> which allows overriding the behaviour, and makes setting the help
> options use this.
> 
> Intended for 4.10 and master.
> 
> 
> Diffs
> -----
> 
>   krunner/interfaces/default/interface.cpp 505e0aa6c02233fba0ff7ae9ce1133e8c7542104 
>   krunner/interfaces/default/resultscene.h 4aa484443c8c75cf683a52c817ac1b1bcbc849db 
>   krunner/interfaces/default/resultscene.cpp 514c2c82d0fe3c3aa04200b5e254a6489bffd89d 
> 
> Diff: http://git.reviewboard.kde.org/r/109160/diff/
> 
> 
> Testing
> -------
> 
> Verified that all help options are shown. No visible side-effects.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130226/4a7b90ac/attachment.html>