Review Request 108969: Visual cleanup, slight design changes(more margins) and auto sizing of text in now playing widget.

[Kai Uwe Broulik]

> On Feb. 15, 2013, 12:07 a.m., Kai Uwe Broulik wrote:
> > applets/nowplaying/package/contents/ui/Controls.qml, line 27
> > <http://git.reviewboard.kde.org/r/108969/diff/1/?file=114046#file114046line27>
> >
> >     You might want to make this adjust to font dpi settings or global icon sizes.
> 
> Tjaart Blignaut wrote:
>     I'm not sure where to look for a solution to this. Can you give me a hint of where to find the functions in qml to get the standard icon sizes?

Have a look at KIconLoader IconSize() http://api.kde.org/4.10-api/kdelibs-apidocs/kdeui/html/classKIconLoader.html
You can access these sizes using theme.iconSizes, see [kde-runtime] plasma/declarativeimports/core/theme.h for available properties.
I guess when default button size is 40, you want to use theme.iconSizes.dialog which is the default size for icons in dialogs and defaults to 32x32 px.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108969/#review27493
-----------------------------------------------------------


On Feb. 18, 2013, 6:45 p.m., Tjaart Blignaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108969/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 6:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch 
> - allows the now playing widget to automatically size text when the widget is sized. The sizing is a function of height with some of the width also causing teh text to size.
> - makes the play controls slighty bigger and easier to press
> - Adds some margins to all the controls
> - makes the progress bar a bit fatter
> - Removed the "by" and "on" text
> 
> 
> Diffs
> -----
> 
>   applets/nowplaying/package/contents/ui/Controls.qml 382ccf6 
>   applets/nowplaying/package/contents/ui/FullLayout.qml c92f5c6 
> 
> Diff: http://git.reviewboard.kde.org/r/108969/diff/
> 
> 
> Testing
> -------
> 
> Tested with some really long tracks like "Counting bodies like sheep with the rythm of the war drum" to see if sizing would work. Tested it on 22" monitor and on 32" television. Sized it to fill each screen horizontally and fill the screen half way vertically.
> 
> 
> File Attachments
> ----------------
> 
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_before.png
> After
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/14/nowplaying_after.png
> With play controls
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/02/18/nowplaying_after_with_widgets.png
> 
> 
> Thanks,
> 
> Tjaart Blignaut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130218/097c6bc2/attachment-0001.html>