Review Request 108957: Adding BAMF support to KWin

[Martin Gräßlin]

> On Feb. 14, 2013, 2:07 p.m., Aaron J. Seigo wrote:
> > licensing wise: due to being released under LGPLv3, BAMF can only be used with GPLv2+ software or compatible. see: http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility .. it seems that kwin is GPLv2+? if so, then that's fine, but should be checked.
> > 
> > otherwise, have you any idea about performance of BAMF? hitting disk to open .desktop files can be expensive, though hopefully it is done rarely, results are cached and BAMF does a good job of locating the .desktop file for a given window (cpu-wise)

concerning licencing. Random KWin header file:
"This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version."
-> should be fine :-)

> otherwise, have you any idea about performance of BAMF?
no I don't but I'd say if it's good enough for Unity it should probably be good enough for us :-)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108957/#review27437
-----------------------------------------------------------


On Feb. 14, 2013, 1:02 p.m., Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108957/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 1:02 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Description
> -------
> 
> Adding BAMF support to KWin
> 
> BAMF is a library used by Unity to match windows to their applications.
> This is also pretty useful for KWin, possible uses are:
> * better filtering on whether two Clients belong to the same application
> * Using the application name as caption in case the window title is bad
> * Getting better icons for window switcher/decorations, mostly important
>   for high resolution displays as icons provided through X property do
>   not include the large icons (e.g. 128x128)
> * Using application name for application menu button
> 
> So far support is added to get the KDesktopFile for a Client and this is
> exported to KWinEffects.
> 
> BAMF is probably also useful in other areas of the workspaces, e.g. for
> libtaskmanager.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6084d7dd7655372506e02abe9f141b73155c5857 
>   cmake/modules/CMakeLists.txt 8d3d58189dbcb9e89d4d9c9aa4f3c1c93abad5e4 
>   cmake/modules/FindQtBAMF.cmake PRE-CREATION 
>   config-workspace.h.cmake 4a2dcbf481bff35c3b05366a3d1a79bb1f400b88 
>   kwin/CMakeLists.txt 2f44c57066913e05062bc1a3c3d8a03e924906dc 
>   kwin/client.h 4cbc20f8e2b3aa31c1c33d63ae90f1f0c9eeefbf 
>   kwin/client.cpp 2ce68fb4a0f108442b3476d39a90895bb1d12ffb 
>   kwin/libkwineffects/kwineffects.h 464d7f2c3261c389dcf2349168b8d67cb691563a 
>   kwin/libkwineffects/kwineffects.cpp 7d522d11e1cc71598e646c972c37f1af2275c3fc 
> 
> Diff: http://git.reviewboard.kde.org/r/108957/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130214/bd339d27/attachment-0001.html>