<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108957/">http://git.reviewboard.kde.org/r/108957/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2013, 2:07 p.m. CET, <b>Aaron J. Seigo</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">licensing wise: due to being released under LGPLv3, BAMF can only be used with GPLv2+ software or compatible. see: http://www.gnu.org/licenses/gpl-faq.html#AllCompatibility .. it seems that kwin is GPLv2+? if so, then that's fine, but should be checked.
otherwise, have you any idea about performance of BAMF? hitting disk to open .desktop files can be expensive, though hopefully it is done rarely, results are cached and BAMF does a good job of locating the .desktop file for a given window (cpu-wise)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">concerning licencing. Random KWin header file:
"This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version."
-> should be fine :-)
> otherwise, have you any idea about performance of BAMF?
no I don't but I'd say if it's good enough for Unity it should probably be good enough for us :-)</pre>
<br />
<p>- Martin</p>
<br />
<p>On February 14th, 2013, 1:02 p.m. CET, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kwin and Plasma.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2013, 1:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adding BAMF support to KWin
BAMF is a library used by Unity to match windows to their applications.
This is also pretty useful for KWin, possible uses are:
* better filtering on whether two Clients belong to the same application
* Using the application name as caption in case the window title is bad
* Getting better icons for window switcher/decorations, mostly important
for high resolution displays as icons provided through X property do
not include the large icons (e.g. 128x128)
* Using application name for application menu button
So far support is added to get the KDesktopFile for a Client and this is
exported to KWinEffects.
BAMF is probably also useful in other areas of the workspaces, e.g. for
libtaskmanager.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(6084d7dd7655372506e02abe9f141b73155c5857)</span></li>
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(8d3d58189dbcb9e89d4d9c9aa4f3c1c93abad5e4)</span></li>
<li>cmake/modules/FindQtBAMF.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>config-workspace.h.cmake <span style="color: grey">(4a2dcbf481bff35c3b05366a3d1a79bb1f400b88)</span></li>
<li>kwin/CMakeLists.txt <span style="color: grey">(2f44c57066913e05062bc1a3c3d8a03e924906dc)</span></li>
<li>kwin/client.h <span style="color: grey">(4cbc20f8e2b3aa31c1c33d63ae90f1f0c9eeefbf)</span></li>
<li>kwin/client.cpp <span style="color: grey">(2ce68fb4a0f108442b3476d39a90895bb1d12ffb)</span></li>
<li>kwin/libkwineffects/kwineffects.h <span style="color: grey">(464d7f2c3261c389dcf2349168b8d67cb691563a)</span></li>
<li>kwin/libkwineffects/kwineffects.cpp <span style="color: grey">(7d522d11e1cc71598e646c972c37f1af2275c3fc)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108957/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>