Review Request 108944: Use custom event in konsolepreviewer

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108944/#review27379
-----------------------------------------------------------

Ship it!


one small comment below, but otherwise this can go in imho :)


plasmate/konsole/konsolepreviewer.cpp
<http://git.reviewboard.kde.org/r/108944/#comment20606>

    this should be a QWeakPointer. QPointer has unnecessary overhead.


- Aaron J. Seigo


On Feb. 13, 2013, 2:43 p.m., Giorgos Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108944/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2013, 2:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> -------
> 
> This patch adds a custom event in konsolepreviewer in order to take the output
> differently from the qInstallMsgHandler.
> 
> My code is in the branch terietor/konsole/event, but I will make a new commit,
> since the commits doesn't offer any valuable information and I would like to keep
> a change like this together in one commit
> 
> 
> This addresses bugs 314653 and 314656.
>     http://bugs.kde.org/show_bug.cgi?id=314653
>     http://bugs.kde.org/show_bug.cgi?id=314656
> 
> 
> Diffs
> -----
> 
>   plasmate/konsole/konsolepreviewer.h 8dd4369 
>   plasmate/konsole/konsolepreviewer.cpp 7e180cb 
>   plasmate/main.cpp 56c9872 
>   plasmate/mainwindow.h 4daaaea 
>   plasmate/mainwindow.cpp 7a96925 
> 
> Diff: http://git.reviewboard.kde.org/r/108944/diff/
> 
> 
> Testing
> -------
> 
> No crashes
> 
> 
> Thanks,
> 
> Giorgos Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130213/e1b8e9bf/attachment-0001.html>