Review Request 108944: Use custom event in konsolepreviewer

Giorgos Tsiapaliokas terietor at gmail.com
Wed Feb 13 14:43:38 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108944/
-----------------------------------------------------------

(Updated Feb. 13, 2013, 2:43 p.m.)


Review request for Plasma.


Changes
-------

add some more info in the description


Description (updated)
-------

This patch adds a custom event in konsolepreviewer in order to take the output
differently from the qInstallMsgHandler.

My code is in the branch terietor/konsole/event, but I will make a new commit,
since the commits doesn't offer any valuable information and I would like to keep
a change like this together in one commit


This addresses bugs 314653 and 314656.
    http://bugs.kde.org/show_bug.cgi?id=314653
    http://bugs.kde.org/show_bug.cgi?id=314656


Diffs
-----

  plasmate/konsole/konsolepreviewer.h 8dd4369 
  plasmate/konsole/konsolepreviewer.cpp 7e180cb 
  plasmate/main.cpp 56c9872 
  plasmate/mainwindow.h 4daaaea 
  plasmate/mainwindow.cpp 7a96925 

Diff: http://git.reviewboard.kde.org/r/108944/diff/


Testing
-------

No crashes


Thanks,

Giorgos Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130213/0a5e353c/attachment-0001.html>


More information about the Plasma-devel mailing list