Review Request 106118: Plasmate: Add KWin Scripting support to konsolepreviewer.

Antonis Tsiapaliokas kok3rs at gmail.com
Tue Feb 12 12:26:29 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106118/
-----------------------------------------------------------

(Updated Feb. 12, 2013, 12:26 p.m.)


Review request for kwin, Plasma, Martin Gräßlin, Sebastian Kügler, and Giorgos Tsiapaliokas.


Changes
-------

In the previous i found some regressions.

1)Sometimes the konsolepreviewer didn't return an output because it couldn't found the /var/kde-user/plasmatepreviewerlog.txt
2)Sometimes when you open a Plasma/Applet package and then a KWin/Script package or in reverse order, then the UI of the konsolepreviewer,
was the one from the previous package.

All the above issues have been fixed.


Description
-------

Hello,

This patch is adding the konsolepreviewer support to the KWin Scripts.
When the user, is pressing the "Execute" button, then the script is being called.
Also on the toolbar, there is a new action with name "konsole". This action is visible only when we are inside to a KWin Script.
All the other packages, have a previewer. So the "konsole" action is located inside the previewer.


Diffs (updated)
-----

  plasmate/konsole/konsolepreviewer.h 8dd4369 
  plasmate/konsole/konsolepreviewer.cpp 7e180cb 
  plasmate/mainwindow.h 4daaaea 
  plasmate/mainwindow.cpp 7a96925 

Diff: http://git.reviewboard.kde.org/r/106118/diff/


Testing
-------


Screenshots
-----------

konsole
  http://git.reviewboard.kde.org/r/106118/s/693/


Thanks,

Antonis Tsiapaliokas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130212/c2fa3d12/attachment.html>


More information about the Plasma-devel mailing list