Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

[David Faure]

> On Feb. 10, 2013, 3:40 p.m., David Faure wrote:
> > kde-modules/KDEInstallDirs.cmake, line 136
> > <http://git.reviewboard.kde.org/r/108889/diff/1/?file=113440#file113440line136>
> >
> >     For an install prefix in /usr, this would make it /usr/qml ... is this really wanted?
> >     
> >     Shouldn't this be QT_PLUGIN_INSTALL_DIR/qml, i.e. /usr/lib/plugins/qml ?
> 
> Sebastian Kügler wrote:
>     Apparently not. I've looked at where the example imports from the Qt codebase install these things, and that is indeed $PREFIX/qml, not inside the plugin directory. This location is also where these imports are being found automatically, i.e. without specifying additional import pathes (which we have to do for Plasma in kdelibs 4).

Well, this isn't Qt. We can install our stuff where-ever we want, as long as the right env var points to it (I forgot the name, but I was told there's such an env var for qtquick2 stuff). But yeah, same defaults can make the setup easier. It's not /usr/qml though.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108889/#review27129
-----------------------------------------------------------


On Feb. 10, 2013, 3:37 p.m., Sebastian Kügler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108889/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2013, 3:37 p.m.)
> 
> 
> Review request for kdelibs, Plasma and David Faure.
> 
> 
> Description
> -------
> 
> This patch adds a variable QML_INSTALL_DIR, pointing to the location to install QtQuick2 imports. These are co-installable with QtQuick 1.x, so we need both dirs. Naming is consistent with the path, so IMPORT is ditched from the name (the path doesn't have imports in it anymore).
> 
> 
> Diffs
> -----
> 
>   kde-modules/KDEInstallDirs.cmake ea132e6 
> 
> Diff: http://git.reviewboard.kde.org/r/108889/diff/
> 
> 
> Testing
> -------
> 
> Used it in plasma-framework, functions as expected.
> 
> 
> Thanks,
> 
> Sebastian Kügler
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130211/14f6de8b/attachment.html>