Review Request 108863: Consider an empty (0x0) IconItem a valid item

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108863/
-----------------------------------------------------------

(Updated Feb. 8, 2013, 8:08 p.m.)


Review request for Plasma and Marco Martin.


Changes
-------

The last patch had regressions


Description (updated)
-------

Only provide a QPixmap() when we couldn't paint the icon (because of empty size).

This fixes a regression in my last change in IconItem where valid would be set to false if the size is empty


Diffs (updated)
-----

  plasma/declarativeimports/core/iconitem.cpp a7e80e0 

Diff: http://git.reviewboard.kde.org/r/108863/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130208/4b25612c/attachment.html>