Review Request 108863: Consider an empty (0x0) IconItem a valid item

Aleix Pol Gonzalez aleixpol at gmail.com
Fri Feb 8 17:20:49 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108863/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Description
-------

This fixes a problem in the Button components by reporting the item as valid if the width or height is 0.

The problem was that since my last change, we'd report it as valid and then the Button wouldn't recognize it back to valid, since it starts by setting the width=height=0.


Diffs
-----

  plasma/declarativeimports/core/iconitem.cpp a7e80e0 

Diff: http://git.reviewboard.kde.org/r/108863/diff/


Testing
-------


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20130208/718e3330/attachment.html>


More information about the Plasma-devel mailing list